Skip to content

Fix detection of class usage in double-quoted strings and heredoc#1661

Merged
kukulich merged 1 commit into
slevomat:masterfrom
c01l:master
Mar 9, 2024
Merged

Fix detection of class usage in double-quoted strings and heredoc#1661
kukulich merged 1 commit into
slevomat:masterfrom
c01l:master

Conversation

@c01l

@c01l c01l commented Feb 6, 2024

Copy link
Copy Markdown
Contributor

I encountered a bug in Sniffs.Namespaces.UnusedUsesSniff that resulted in reporting too many "unused" classes, if a class instantiation occurred inside of a double quoted string or heredoc.

Quick example (HTML composition):

<?php

use SomeNamespace\MessageBox;

$_ = fn($x) => strval($x);
$html .= <<<HTML
<div>
   <div>...</div>
   {$_(new MessageBox("User did something wrong."))}
</div>
HTML
<?php

namespace SomeNamespace;

class MessageBox {
  public function __construct(private string $msg) {}
  public function __toString(): string {
    return "<div class='alert alert-danger'>$this->msg</div>";
  }
}

I added some tests for this case and added logic for detecting T_NEW T_STRING as class references.

@kukulich

kukulich commented Mar 9, 2024

Copy link
Copy Markdown
Contributor

Thanks.

@kukulich
kukulich merged commit 74b296b into slevomat:master Mar 9, 2024
@kukulich kukulich added the Bug label Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@c01l @kukulich