Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not unmount slide too far away #2079

Merged
merged 1 commit into from
Feb 22, 2025
Merged

Conversation

kermanx
Copy link
Member

@kermanx kermanx commented Feb 21, 2025

The line removed in this PR was added by me, which I thought could improve the performance by limiting the number of DOM nodes. But this will cause the nodes to frequently unmount and remount. I am not sure about the best way to do this.

Also resolves #1961.

Copy link

netlify bot commented Feb 21, 2025

Deploy Preview for slidev ready!

Name Link
🔨 Latest commit d40ae78
🔍 Latest deploy log https://app.netlify.com/sites/slidev/deploys/67b88236c0e8e0000897d831
😎 Deploy Preview https://deploy-preview-2079--slidev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Feb 21, 2025

Open in Stackblitz

@slidev/client

npm i https://pkg.pr.new/slidevjs/slidev/@slidev/client@2079

create-slidev

npm i https://pkg.pr.new/slidevjs/slidev/create-slidev@2079

create-slidev-theme

npm i https://pkg.pr.new/slidevjs/slidev/create-slidev-theme@2079

@slidev/parser

npm i https://pkg.pr.new/slidevjs/slidev/@slidev/parser@2079

@slidev/types

npm i https://pkg.pr.new/slidevjs/slidev/@slidev/types@2079

@slidev/cli

npm i https://pkg.pr.new/slidevjs/slidev/@slidev/cli@2079

commit: d40ae78

@antfu antfu merged commit 6d2fd55 into slidevjs:main Feb 22, 2025
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Persist component without re-mounting throughout pages
2 participants