Fix UI culture of message loop not getting updated

sliekens · Feb 2, 2025 · bb899cb · bb899cb
1 parent d29cad7
commit bb899cb
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/Blish HUD/GameServices/OverlayService.cs b/Blish HUD/GameServices/OverlayService.cs
@@ -225,8 +225,9 @@ private void ShowInTaskbarOnSettingChanged(object sender, ValueChangedEventArgs<
         private void UserLocaleOnSettingChanged(object sender, ValueChangedEventArgs<Locale> e) {
             var culture = GetCultureFromGw2Locale(e.NewValue);
 
+            // Update the UI culture for the entire application domain by setting DefaultThreadCurrentUICulture
+            // DO NOT change CurrentUICulture, otherwise running threads will NOT get updated with the new default.
             CultureInfo.DefaultThreadCurrentUICulture = culture;
-            CultureInfo.CurrentUICulture              = culture;
 
             this.UserLocaleChanged?.Invoke(this, new ValueEventArgs<CultureInfo>(culture));
         }