Updated conditional glow to accept 1D inputs#119
Updated conditional glow to accept 1D inputs#119grantbruer wants to merge 2 commits intoslimgroup:masterfrom
Conversation
|
This overlaps with #86. @rafaelorozco Are you okay with merging the changes in this PR? Will it mess up your WIP PR? |
Yes you can merge. We only need to worry about those GPU tests. They are tied to a SLIM computer that I believe keeps turning off. We need to move it to another one that is more resilient. |
|
Thanks for getting the gpu tests running. I'll try to figure out why the gpu test is failing before I merge. |
|
I tested this on my gpu, and it passes the tests now. I think this PR is ready to merge now, once we get the gpu CI running. I changed the step size for a couple of the gradient tests, and in |
This PR updates the coupling layer in the conditional Glow implementation.
The coupling layer does the following:
xin half,yand half ofxto a smaller neural network,x.This PR makes the minimal changes required to allow
xto be a scalar value. When the state is split in half, this PR updates the code so that the "half" that goes to the smaller network is empty while the "half" that is updated has size 1.