Skip to content

translations: Upgrade compiler and extractor to new polib version #10280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
tronical wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

translations: Upgrade compiler and extractor to new polib version #10280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/compiler/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ fdsm-ttf-parser = { version = "0.2", optional = true }
nalgebra = { version = "0.34.0", optional = true }
rayon = { workspace = true, optional = true }
# translations
polib = { version = "0.2", optional = true }
polib = { version = "0.3", optional = true }

pathdiff = { version = "0.2.3", optional = true }

Expand Down
2 changes: 1 addition & 1 deletion tools/tr-extractor/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ categories = ["gui", "command-line-utilities", "development-tools"]
i-slint-compiler = { workspace = true, features = ["default", "display-diagnostics"] }
chrono = { version = "0.4.24", default-features = false, features = ["clock"] }
clap = { workspace = true }
polib = "0.2"
polib = "0.3"
smol_str = { workspace = true }

[dev-dependencies]
Expand Down
4 changes: 2 additions & 2 deletions tools/tr-extractor/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ fn main() -> std::io::Result<()> {
process_file(path, &mut messages, &args)?
}

polib::po_file::write(&messages, &output)?;
polib::po_file::write_to_file(&messages, &output)?;
Ok(())
}

Expand Down Expand Up @@ -147,7 +147,7 @@ fn visit_node(
}
}

let comment = msg.comments_mut();
let comment = msg.extracted_comments_mut();
if comment.is_empty() {
if let Some(c) = tr
.child_token(SyntaxKind::StringLiteral)
Expand Down
Loading