wgpu fixes #10340
Merged
wgpu fixes #10340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tronical
reviewed
Jan 2, 2026
Member
tronical
left a comment
tronical
left a comment
There was a problem hiding this comment.
Thanks - looks good to me! Just one question within about the resizing handling.
| } | ||
|
|
||
| fn resize_event(&self, size: PhysicalWindowSize) -> Result<(), PlatformError> { | ||
| if size.width == 0 || size.height == 0 { |
Member
There was a problem hiding this comment.
I‘m surprised that this is needed in light of 0db8650 . Is there another call site for this function?
Contributor
Author
There was a problem hiding this comment.
I needed this commit on top of 1.14.1 and didn't see during rebase that it was fixed in master in that other function already.
I removed the commit.
The surface capabilities don't only list formats that are usable for render attachments. Since those formats should be available most of the time, pick either BGRA or RGBA from the list of supported formats. Fixes slint-ui#10233
tronical
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #xxxorCloses #xxxChangeLog: ...