Add semantic analysis benchmarks and optimization documentation #10373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfaure-kdab
reviewed
Jan 5, 2026
| )); | ||
| } | ||
|
|
||
| /// Phase 3: Load dependencies (style-base.slint and its deps) |
Contributor
There was a problem hiding this comment.
There's no style-base.slint in the repo or in this PR
Contributor
Author
There was a problem hiding this comment.
Ah, that snuck in from a refactoring later in the patch series. The one that acutally improves the benchmark ;). Will fix.
dfaure-kdab
reviewed
Jan 5, 2026
| // Benchmark just the import_component calls | ||
| let mut build_diags_to_ignore = BuildDiagnostics::default(); | ||
| let _style_metrics = spin_on::spin_on(loader.import_component( | ||
| "style-base.slint", |
Contributor
There was a problem hiding this comment.
ah, it's not just a comment, it's referred to here
dfaure-kdab
reviewed
Jan 5, 2026
| &mut build_diags_to_ignore, | ||
| )); | ||
| divan::black_box((_style_metrics, _palette)); | ||
| use super::*; |
Contributor
There was a problem hiding this comment.
leftover? doesn't seem useful here?
Contributor
Author
There was a problem hiding this comment.
Patch order problem, yes. I wanted to present the benchmark separately from the changes, which apparently didn't quite work.
Contributor
There was a problem hiding this comment.
I guess your reply was for the previous comment.
This one is about use super::*;
- Add divan benchmarks for compiler semantic analysis phase (internal/compiler/benches/semantic_analysis.rs) - Add custom allocator to track allocations in the benchmark. - Add benches for individual phases of compilation and a proc-macro simulation mode. - Document allocation hotspots and optimization strategies (docs/semantic-analysis-optimization.md) Benchmarks cover: - Lexing and parsing performance - Full compilation with various stress scenarios - Specific hotspots: many children, properties, exports, states, nested components, deep expressions, binding chains The optimization doc identifies key issues: - O(n²) export sorting - Element duplication in inlining pass - Incremental Vec growth patterns - SmallVec sizing recommendations
tilladam
force-pushed
the
compiler-benchmark
branch
from
b2a065a to
bcaf099
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add divan benchmarks for compiler semantic analysis phase (internal/compiler/benches/semantic_analysis.rs)
Add custom allocator to track allocations in the benchmark.
Add benches for individual phases of compilation and a proc-macro simulation mode.
Document allocation hotspots and optimization strategies (docs/semantic-analysis-optimization.md)
Benchmarks cover:
The optimization doc identifies key issues: