Skip to content

Add get_elipsis_glyph function #10384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
expenses merged 1 commit into from
Jan 12, 2026
Merged

Add get_elipsis_glyph function #10384

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions internal/core/textlayout/sharedparley.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,20 +396,24 @@ fn layout(
let max_physical_width = options.max_width.map(|max_width| max_width * scale_factor);
let max_physical_height = options.max_height.map(|max_height| max_height * scale_factor);

let elision_info = if let (TextOverflow::Elide, Some(max_physical_width)) =
(options.text_overflow, max_physical_width)
{
// Returned None if failed to get the elipsis glyph for some rare reason.
let get_elipsis_glyph = || {
let mut layout = layout_builder.build("…", None, None, None);
layout.break_all_lines(None);
let line = layout.lines().next().unwrap();
let item = line.items().next().unwrap();
let line = layout.lines().next()?;
let item = line.items().next()?;
let run = match item {
parley::layout::PositionedLayoutItem::GlyphRun(run) => Some(run),
_ => None,
}
.unwrap();
let glyph = run.positioned_glyphs().next().unwrap();
Some(ElisionInfo { elipsis_glyph: glyph, max_physical_width })
_ => return None,
}?;
let glyph = run.positioned_glyphs().next()?;
Some(glyph)
};

let elision_info = if let (TextOverflow::Elide, Some(max_physical_width)) =
(options.text_overflow, max_physical_width)
{
get_elipsis_glyph().map(|elipsis_glyph| ElisionInfo { elipsis_glyph, max_physical_width })
} else {
None
};
Expand Down
Loading