remove finalizer on Close #183
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbedard
added a commit
to aspect-build/aspect-cli
that referenced
this pull request
Apr 1, 2025
Fix #818 See also: smacker/go-tree-sitter#183 smacker/go-tree-sitter#182 --- ### Changes are visible to end-users: yes - Searched for relevant documentation and updated as needed: yes - Breaking change (forces users to change their own code or config): no - Suggested release notes appear below: yes Ensure `configure` tree-sitter resources are explicitly cleaned up. ### Test plan - Covered by existing test cases GitOrigin-RevId: 35c3509f084f0d7c2e01a9d11faa2519462dc46b
jbedard
added a commit
to aspect-build/aspect-cli
that referenced
this pull request
Apr 1, 2025
Fix #818 See also: smacker/go-tree-sitter#183 smacker/go-tree-sitter#182 --- ### Changes are visible to end-users: yes - Searched for relevant documentation and updated as needed: yes - Breaking change (forces users to change their own code or config): no - Suggested release notes appear below: yes Ensure `configure` tree-sitter resources are explicitly cleaned up. ### Test plan - Covered by existing test cases GitOrigin-RevId: 35c3509f084f0d7c2e01a9d11faa2519462dc46b
jbedard
added a commit
to aspect-build/aspect-cli
that referenced
this pull request
Apr 2, 2025
Fix #818 See also: smacker/go-tree-sitter#183 smacker/go-tree-sitter#182 --- ### Changes are visible to end-users: yes - Searched for relevant documentation and updated as needed: yes - Breaking change (forces users to change their own code or config): no - Suggested release notes appear below: yes Ensure `configure` tree-sitter resources are explicitly cleaned up. ### Test plan - Covered by existing test cases GitOrigin-RevId: 35c3509f084f0d7c2e01a9d11faa2519462dc46b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leaving additional finalizers around consumes memory (to store the finalizer), and has a runtime cost (there's a single runtime go-routine which loops over all finalizers). They can be cleaned up on manual Close.
See this maintainer comment and the runtime docs.