Upgrade react native 0.79.4 + Removed Mixpanel from Native Android/IOS SDKs #106

dporwal-shipit · 2025-07-30T10:43:11Z

No description provided.

…w tracking - Replaced Mixpanel tracking calls in SCLoans with internal analytics events - Removed Mixpanel SDK dependency from gradle - Verified build and functionality on working version

dporwal-shipit · 2025-08-26T09:54:30Z

React-Native Bridge for Android successfully propagating events from Native Android SDK(Producer) to Smart Investing Appln (Consumer):

For SCGateway:

For SCLoans:

React-Native Bridge for IOS successfully propagating events from Native Android IOS(Producer) to Smart Investing Appln (Consumer):

For SCGateway:

For SCLoans:

…intainability - Simplified event flow between native and JS layers - Improved code readability and reduced complexity - Easier to extend with new analytics events in future

…ved maintainability - Simplified event flow between native and JS layers - Improved code readability and reduced complexity - Easier to extend with new analytics events in future

LonelyCpp · 2025-09-01T10:59:52Z

smart_investing_react_native/App.tsx

install the "prettier" vscode extention for formatting js files. make sure that it matches the older style

(here the diff should only show changes that you've already made)

Error: Cannot find module 'prettier' from '/Users/dhruvporwal/smallcase/react-native-smallcase-gateway'
at e.exports [as sync] (/Users/dhruvporwal/.vscode/extensions/esbenp.prettier-vscode-11.0.0/dist/extension.js:1:38498)

Unable to do for .js files. Would i have to add prettier to project? Because i have added prettier as default formatter in settings.json already:

{

"security.workspace.trust.untrustedFiles": "open",
"dart.flutterSdkPath": "/Users/dhruvporwal/fvm/versions/stable",
"git.enableSmartCommit": true,
"files.autoSave": "afterDelay",
"diffEditor.ignoreTrimWhitespace": true,
"gitlens.ai.model": "gitkraken",
"gitlens.ai.gitkraken.model": "gemini:gemini-2.0-flash",
"dart.debugExternalPackageLibraries": true,
"dart.debugSdkLibraries": true,
"editor.formatOnSave": true,
"prettier.resolveGlobalModules": true,
"editor.formatOnPaste": true,
"editor.formatOnType": true,
"editor.defaultFormatter": "esbenp.prettier-vscode",
"notebook.defaultFormatter": "esbenp.prettier-vscode"
}

LonelyCpp · 2025-09-01T11:02:34Z

src/SmallcaseGateway.js

  return SmallcaseGatewayNative.archiveSmallcase(safeIscid);
 };

 /**
 * Returns the native android/ios and react-native sdk version
- * (internal-tracking)
- * @returns {Promise}


why did we remove these return and param types?

They have been added back.

LonelyCpp · 2025-09-01T11:03:00Z

src/SmallcaseGateway.js

+
+/**
+ * 🔕 Unsubscribe from Gateway Event
+ * @param {object} subscription - Subscription returned from startGatewayEventListening


these param and return types can be better. make it closer to the actual types, instead of generic types

LonelyCpp · 2025-09-01T11:04:51Z

src/SCLoansEventEmitter.js

+        this.isInitialized = true;
+        console.log('[SCLoansEvents] Initialized for', Platform.OS);
+      } else {
+        console.warn('[SCLoansEvents] Native module not found for', Platform.OS);


this probably should be thrown as an error. shouldn't silently fail

LonelyCpp · 2025-09-01T11:05:35Z

src/SCLoansEventEmitter.js

+    }
+
+    try {
+      const subscription = this.eventEmitter.addListener('scloans_notification', (eventData) => {


keep all these strings ("scloans_notification") as constants. don't use them directly

LonelyCpp · 2025-09-01T11:06:30Z

src/SCLoansEventEmitter.js

+          type: eventData.eventType || eventData.type || 'unknown_event',
+          eventType: eventData.eventType || eventData.type || 'unknown_event',
+          data: eventData.data || eventData,
+          timestamp: eventData.timestamp || Date.now(),


do these fallbacks make sense?

please check with the analytics team on what should be the correct fallback values such that invalid values don't make it into real analysis

LonelyCpp · 2025-09-01T11:07:47Z

src/SCLoansEventEmitter.js

+
+      this.subscriptions.push(subscription);
+
+      console.log('SCLoansEvents Subscribed to gateway events');


remove all these console logs from the SDK

LonelyCpp · 2025-09-01T11:08:59Z

src/SCLoansEventEmitter.js

+        const index = this.subscriptions.indexOf(subscription);
+        if (index > -1) {
+          this.subscriptions.splice(index, 1);
+        }


better to use array.filter()

LonelyCpp · 2025-09-01T11:10:29Z

src/SCGatewayEventEmitter.js

+  USER_IDENTIFY: 'scgateway_user_identify',
+};
+
+export class SCGatewayEvents {


here again, a lot of the event emitter code is duplicated.

structure it in a way where things can be shared as much as possible

Actually we are treating both the sdks as separate and isolated. So, created separate files to support this. Same is true in android implementation as well for Notification Center.

indrajit-roy-sc · 2025-09-05T05:21:13Z