Skip to content

Conversation

tashian
Copy link
Contributor

@tashian tashian commented Feb 8, 2023

New output:

bin/step ca bootstrap --ca-url https://ca:4443 --fingerprint abc123
The request could not be completed: a root certificate with that fingerprint was not found.
Re-run with STEPDEBUG=1 for more info.

@tashian tashian requested a review from maraino February 8, 2023 19:40
@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label Feb 8, 2023
return nil, clientError(err)
}
if resp.StatusCode == 404 {
defer resp.Body.Close()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this was actually needed here.

Copy link
Contributor

@maraino maraino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is the right place to do it.

We should manage this in the CLI. And in the API side of certificates if we want a better message, currently it returns:

$ curl -s https://localhost:9000/root/foo | jq
{
  "status": 404,
  "message": "The requested resource could not be found. Please see the certificate authority logs for more info."
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Waiting for discussion / prioritization by team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants