-
Notifications
You must be signed in to change notification settings - Fork 495
Use container secrets securely #2271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
88689aa
to
2f8e30d
Compare
did a bit more testing:
|
71ef567
to
dd11516
Compare
307f599
to
a5eaa57
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for this PR @itoffshore. You get bonus points for including Podman examples. 👏🏼👏🏼 I use Podman with Quadlets for all of my homelab container deployments, including step ca.
I have left a detailed review. If you can make the requested changes that would be great, and we can get this merged.
I can fix it here && here
all the changes should be there Quadlets are great - on to pods next if you love Making customised iso images with "kiwi" is great. RKE2 can be run on it very easily.
|
2bce8ba
to
4b6d1c6
Compare
4e94de2
to
37a0402
Compare
* adds a new ENV variable DOCKER_STEPCA_PASSWORD_FILE so the password file location can be changed * adds set_password_files() to entrypoint.sh so /home/step/secrets/password becomes a symlink in containers pointing to DOCKER_STEPCA_INIT_PASSWORD_FILE & also DOCKER_STEPCA_PASSWORD_FILE so file permissions are retained * adds podman example quadlet / run command with a 378,000 character secret * small update to README.md for new podman examples / docker examples Fixes smallstep#2270
ENV
variableDOCKER_STEPCA_PASSWORD_FILE
so the password file location can be changed / set on everyrun
set_password_files()
toentrypoint.sh
so/home/step/secrets/password
becomes asymlink
in containers pointing toDOCKER_STEPCA_INIT_PASSWORD_FILE
(for backwards compatibility) & alsoDOCKER_STEPCA_PASSWORD_FILE
so secret file permissions are retainedopenssl
using an8192
characterhex
string.container
exampleREADME.md
for newpodman
examples /docker
examplesFixes #2270
Name of feature:
Pain or issue this feature alleviates:
Why is this important to the project (if not answered above):
Is there documentation on how to use this feature? If so, where?
In what environments or workflows is this feature supported?
In what environments or workflows is this feature explicitly NOT supported (if any)?
Supporting links/other PRs/issues: #2270
💔Thank you!