Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lazy-start LogPoller from ContractReader, stop if started on shutdown #1051

Merged
merged 12 commits into from
Feb 12, 2025
Merged

Lazy-start LogPoller from ContractReader, stop if started on shutdown #1051

merged 12 commits into from
Feb 12, 2025
+404 −22

Conversation

reductionista
Copy link
Contributor

@reductionista reductionista commented Feb 7, 2025 •
edited
Loading

Description

  • Start LogPoller from ChainReader, if there are events defined in ChainReaderConfig, and it's not already started yet
  • Adds a lot more testing coverage to ChainReader's Start() method

JIRA: NONEVM-1286

@reductionista reductionista force-pushed the chore/NONEVM-1286-start-logpoller branch from 51ee0cb to ff0e81f Compare February 7, 2025 22:30
@reductionista reductionista marked this pull request as ready for review February 7, 2025 22:31
@reductionista reductionista requested a review from a team as a code owner February 7, 2025 22:31
@reductionista reductionista force-pushed the chore/NONEVM-1286-start-logpoller branch from ead0465 to 6ca9812 Compare February 7, 2025 23:15
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
1.3% Coverage on New Code (required ≥ 75%)

See analysis details on SonarQube

@jadepark-dev jadepark-dev merged commit 77f8e8f into develop Feb 12, 2025
34 of 36 checks passed
@jadepark-dev jadepark-dev deleted the chore/NONEVM-1286-start-logpoller branch February 12, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jadepark-dev jadepark-dev jadepark-dev approved these changes

@dhaidashenko dhaidashenko dhaidashenko approved these changes

@ilija42 ilija42 ilija42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@reductionista @jadepark-dev @dhaidashenko @ilija42