Implement multi read parent read params usage #1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilija42
had a problem deploying
to
integration
GitHub Actions
Failure
ilija42
had a problem deploying
to
integration
GitHub Actions
Failure
ilija42
had a problem deploying
to
integration
GitHub Actions
Failure
EasterTheBunny
approved these changes
Feb 11, 2025
amit-momin
approved these changes
Feb 11, 2025
ilija42
had a problem deploying
to
integration
GitHub Actions
Failure
ilija42
had a problem deploying
to
integration
GitHub Actions
Failure
| // this works by having hard coder codec modifier define fields that are filled out by subsequent reads. | ||
| multiRead []string | ||
| // reads of size one is a regular Account read. | ||
| // When multiple read reads are present, first read has type info that other sequential reads are filling out. |
There was a problem hiding this comment.
should "multiple read reads" say "multiple reads"?
|
chris-de-leon-cll
approved these changes
Feb 11, 2025
toblich
approved these changes
Feb 11, 2025
| #[account( | ||
| init_if_needed, | ||
| payer = signer, | ||
| space = size_of::<MultiRead3>() + 8, |
There was a problem hiding this comment.
Suggestion: instead of doing this size_of::, the Anchor way of doing this is to:
- Add
#[derive(InitSpace)]to the struct - Use
MultRead3::INIT_SPACEhere
See the docs. That way it will also handle some other types, such as vectors (where you can specify amax_lento it for example).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enables CR to multi read same PDA account multiple times, this is useful for handling very complex chain agnostic <> chain specific data restructuring without having to immediately develop new codec modifiers.