ref: migrate Offramp.spec to abigen wrappers - #798
Merged
Conversation
…atible with autogenerated bindings
duck-types
force-pushed
the
chore/migrate-to-abigen-offramp
branch
from
July 16, 2026 20:49
98f7367 to
ba3ece6
Compare
duck-types
force-pushed
the
chore/migrate-to-abigen-offramp
branch
from
July 16, 2026 23:03
22b66fa to
8dab672
Compare
duck-types
force-pushed
the
chore/migrate-to-abigen-offramp
branch
from
July 17, 2026 16:14
8dab672 to
6e2b84b
Compare
vicentevieytes
approved these changes
Jul 21, 2026
krebernisak
reviewed
Jul 28, 2026
| } | ||
|
|
||
| // --------------------------------------------------------------------------- | ||
| // map<K, V> / map<K, ()> ergonomic transform |
Collaborator
There was a problem hiding this comment.
What if this breaks and someone needs to debug this?
imo this adds unnecessary complexity and simple util functions + not hiding types/internals is a lot more straightforward which keeps us productive vs having the perfect abigen/api
the initial builder pattern bindings would have worked fine to launch and beyond (these are simple types) without needing abigen + custom extensions + multiple refactors, etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make abigen wrappers more ergonomic:
Migrate offramp.spec to generated bindings