feat: Adding support for Kubernetes to local CRE #20519

njegosrailic · 2025-12-04T15:11:57Z

What

Adding support for Kubernetes to local CRE.

Example infra configuration:

[infra]
  type = "kubernetes"

  [infra.kubernetes]
    namespace = "cre"
    external_domain = "my-domain.com"
    external_port = 80
    label_selector = "app=chainlink"
    node_api_user = "[email protected]"
    node_api_password = "password"

Requires

N/A

Supports

N/A

github-actions · 2025-12-04T15:13:23Z

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

#added For any new functionality added.
#breaking_change For any functionality that requires manual action for the node to boot.
#bugfix For bug fixes.
#changed For any change to the existing functionality.
#db_update For any feature that introduces updates to database schema.
#deprecation_notice For any upcoming deprecation functionality.
#internal For changesets that need to be excluded from the final changelog.
#nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
#removed For any functionality/config that is removed.
#updated For any functionality that is updated.
#wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

cl-sonarqube-production · 2025-12-04T15:58:24Z

Quality Gate passed

Issues
5 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

trunk-io · 2025-12-04T17:05:38Z

Failed Test	Failure Summary	Logs
`Test_CRE_V2_HTTP_Action_Suite`	The test failed without a specific error message, likely due to a timeout or an unhandled failure in the HTTP action suite.	Logs ↗︎
`Test_CRE_V2_HTTP_Action_Suite/[v2]_HTTP_Action_PUT_operation`	The test failed without a specific error message, indicating an unspecified issue during the HTTP action workflow execution.	Logs ↗︎

_{View Full Report ↗︎ ⋅ Docs}

Tofel · 2025-12-05T15:12:49Z

system-tests/lib/cre/environment/blockchains/blockchains.go

 func Start(
 	ctx context.Context,
 	testLogger zerolog.Logger,
 	commonLogger logger.Logger,
 	inputs []*blockchain.Input,
 	deployers map[blockchain.ChainFamily]Deployer,
+	provider *infra.Provider,


why do we need it? deployers already have access to provider. Check here: https://github.com/smartcontractkit/chainlink/blob/develop/system-tests/lib/cre/environment/blockchains/evm/evm.go#L45

Tofel · 2025-12-05T15:19:21Z

system-tests/lib/cre/environment/dons.go

@@ -56,6 +56,7 @@ func StartDONs(
 	capabilityConfigs cre.CapabilityConfigs,
 	copyCapabilityBinaries bool,
 	nodeSets []*cre.NodeSet,
+	apiUser, apiPassword string,


I'd rather have a API user/password provider that would return this or that value per each infra type and inject that here than have user/password fields that are only used in case of k8s. It will be confusing for users.

Tofel · 2025-12-05T15:20:44Z

system-tests/lib/cre/environment/dons.go

@@ -70,31 +71,48 @@ func StartDONs(
 		if devspaceErr != nil {
 			return nil, pkgerrors.Wrap(devspaceErr, "failed to deploy Dons with crib-sdk")
 		}
-	}
+	} else if infraInput.IsKubernetes() {


could we use switch instead of ifs? here and in all the other places that care about infra type 🙏

Tofel · 2025-12-05T15:21:26Z

system-tests/lib/cre/environment/dons.go

-			if flags.HasFlagForAnyChain(donMetadata.Flags, flag) && config.BinaryPath != "" {
-				customBinariesPaths[flag] = config.BinaryPath
+	// Skip binary operations for Kubernetes (binaries are in the cluster images)
+	if !infraInput.IsKubernetes() {


since this copying has to be done only for Docker why not do this instead:

if infra.IsDocker() { // copy code goes here }

Tofel · 2025-12-05T15:22:43Z

system-tests/lib/cre/environment/dons.go

-		infra.PrintFailedContainerLogs(lggr, 30)
+		if !infraInput.IsKubernetes() {
+			infra.PrintFailedContainerLogs(lggr, 30)
+		}


if infraInput.IsDocker() { infra.PrintFailedContainerLogs(lggr, 30) }

Tofel · 2025-12-05T15:23:44Z

system-tests/lib/cre/environment/environment.go

+		}
+		if apiPassword == "" {
+			apiPassword = "password" // Required default for testing
+		}


as mentioned before, this should all be encapsulated in a credentials provider

Tofel · 2025-12-05T15:24:16Z

system-tests/lib/cre/environment/environment.go

 		// as we don't have a way to get its database connection string
-		if input.Provider.Type == infra.CRIB {
+		if input.Provider.Type == infra.CRIB || input.Provider.IsKubernetes() {


if !input.Provider.IsDocker() { return nil }

Tofel · 2025-12-05T15:29:01Z

system-tests/lib/infra/kubernetes.go

+func GenerateKubernetesJDOutput(infraInput *Provider, lggr zerolog.Logger) *jd.Output {
+	externalDomain := ""
+
+	if infraInput.Kubernetes != nil {


why not just return err if infraInput.Kubernetes is nil and never check it again?

Tofel · 2025-12-05T15:29:36Z

system-tests/lib/infra/kubernetes.go

+func GenerateKubernetesNodeSetOutput(infraInput *Provider, nodeSetName string, nodeCount int, nodeMetadataRoles []bool, apiUser, apiPassword string, lggr zerolog.Logger) *ns.Output {
+	externalDomain := ""
+
+	if infraInput.Kubernetes != nil {


same, check early and return err if it is nil

njegosrailic changed the title ~~feat: Adding support for Kubernetes~~ feat: Adding support for Kubernetes to local CRE Dec 4, 2025

njegosrailic requested a review from Tofel December 4, 2025 15:15

njegosrailic force-pushed the add-kubernetes-support branch from 19717f4 to f2a509a Compare December 4, 2025 15:26

feat: Adding support for Kubernetes

2dd7429

njegosrailic force-pushed the add-kubernetes-support branch from f2a509a to 2dd7429 Compare December 4, 2025 15:41

Tofel reviewed Dec 5, 2025

View reviewed changes

feat: Adding support for Kubernetes to local CRE #20519

Are you sure you want to change the base?

feat: Adding support for Kubernetes to local CRE #20519

Uh oh!

Conversation

njegosrailic commented Dec 4, 2025

What

Requires

Supports

Uh oh!

github-actions bot commented Dec 4, 2025

Uh oh!

cl-sonarqube-production bot commented Dec 4, 2025

Quality Gate passed

Uh oh!

trunk-io bot commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Tofel Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Tofel Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

Tofel Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

Tofel Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Tofel Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

Tofel Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

Tofel Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

Tofel Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

Tofel Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

trunk-io bot commented Dec 4, 2025 •

edited

Loading

Tofel Dec 5, 2025 •

edited

Loading

Tofel Dec 5, 2025 •

edited

Loading