-
Notifications
You must be signed in to change notification settings - Fork 1.9k
disable flaky tests temporarily & update version #20531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR temporarily disables two flaky CCIP upgrade tests related to EVM to Sui integration by commenting them out in the integration test configuration file.
Key changes:
- Commented out
Test_CCIP_Upgrade_EVM2Suitest configuration - Commented out
Test_CCIP_Upgrade_CommonPkg_EVM2Suitest configuration
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # - id: smoke/ccip/ccip_sui_upgrade_test.go:Test_CCIP_Upgrade_EVM2Sui | ||
| # path: integration-tests/smoke/ccip/ccip_sui_upgrade_test.go | ||
| # test_env_type: in-memory | ||
| # runs_on_self_hosted: runs-on/cpu=16/ram=64/family=m6i+m5.*/spot=false/image=ubuntu24-full-x64/extras=s3-cache+tmpfs | ||
| # triggers: | ||
| # - PR Integration CCIP Tests | ||
| # - Nightly Integration CCIP Tests | ||
| # test_cmd: | | ||
| # go test ./smoke/ccip -run "Test_CCIP_Upgrade_EVM2Sui" -timeout 25m -test.parallel=1 -count=1 -json | ||
| # test_go_project_path: integration-tests | ||
| # sui_cli_version: mainnet-1.60.1 | ||
| # install_plugins_public: true | ||
| # free_disk_space: true |
Copilot
AI
Dec 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a comment explaining why these tests are disabled and reference a tracking issue (e.g., 'Temporarily disabled due to flakiness - see LINK-777'). This helps maintainers understand when and why these tests should be re-enabled.
| # - id: smoke/ccip/ccip_sui_upgrade_test.go:Test_CCIP_Upgrade_CommonPkg_EVM2Sui | ||
| # path: integration-tests/smoke/ccip/ccip_sui_upgrade_test.go | ||
| # test_env_type: in-memory | ||
| # runs_on: ubuntu-latest | ||
| # triggers: | ||
| # - PR Integration CCIP Tests | ||
| # - Nightly Integration CCIP Tests | ||
| # test_cmd: | | ||
| # go test ./smoke/ccip -run "Test_CCIP_Upgrade_CommonPkg_EVM2Sui" -timeout 25m -test.parallel=1 -count=1 -json | ||
| # test_go_project_path: integration-tests | ||
| # sui_cli_version: mainnet-1.60.1 | ||
| # install_plugins_public: true | ||
| # free_disk_space: true |
Copilot
AI
Dec 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a comment explaining why these tests are disabled and reference a tracking issue (e.g., 'Temporarily disabled due to flakiness - see LINK-777'). This helps maintainers understand when and why these tests should be re-enabled.
|
added a ticket to track fixing these: https://smartcontract-it.atlassian.net/browse/NONEVM-2558 |
6eeed22
|





Requires
Supports