Skip to content

Conversation

@FelixFan1992
Copy link
Contributor

Requires

Supports

@FelixFan1992 FelixFan1992 requested a review from ro-tex December 5, 2025 14:20
@FelixFan1992 FelixFan1992 marked this pull request as ready for review December 5, 2025 14:20
@FelixFan1992 FelixFan1992 requested a review from a team as a code owner December 5, 2025 14:20
Copilot AI review requested due to automatic review settings December 5, 2025 14:20
@FelixFan1992 FelixFan1992 requested review from a team as code owners December 5, 2025 14:20
ro-tex
ro-tex previously approved these changes Dec 5, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR temporarily disables two flaky CCIP upgrade tests related to EVM to Sui integration by commenting them out in the integration test configuration file.

Key changes:

  • Commented out Test_CCIP_Upgrade_EVM2Sui test configuration
  • Commented out Test_CCIP_Upgrade_CommonPkg_EVM2Sui test configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +943 to +955
# - id: smoke/ccip/ccip_sui_upgrade_test.go:Test_CCIP_Upgrade_EVM2Sui
# path: integration-tests/smoke/ccip/ccip_sui_upgrade_test.go
# test_env_type: in-memory
# runs_on_self_hosted: runs-on/cpu=16/ram=64/family=m6i+m5.*/spot=false/image=ubuntu24-full-x64/extras=s3-cache+tmpfs
# triggers:
# - PR Integration CCIP Tests
# - Nightly Integration CCIP Tests
# test_cmd: |
# go test ./smoke/ccip -run "Test_CCIP_Upgrade_EVM2Sui" -timeout 25m -test.parallel=1 -count=1 -json
# test_go_project_path: integration-tests
# sui_cli_version: mainnet-1.60.1
# install_plugins_public: true
# free_disk_space: true
Copy link

Copilot AI Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment explaining why these tests are disabled and reference a tracking issue (e.g., 'Temporarily disabled due to flakiness - see LINK-777'). This helps maintainers understand when and why these tests should be re-enabled.

Copilot uses AI. Check for mistakes.
Comment on lines +957 to +969
# - id: smoke/ccip/ccip_sui_upgrade_test.go:Test_CCIP_Upgrade_CommonPkg_EVM2Sui
# path: integration-tests/smoke/ccip/ccip_sui_upgrade_test.go
# test_env_type: in-memory
# runs_on: ubuntu-latest
# triggers:
# - PR Integration CCIP Tests
# - Nightly Integration CCIP Tests
# test_cmd: |
# go test ./smoke/ccip -run "Test_CCIP_Upgrade_CommonPkg_EVM2Sui" -timeout 25m -test.parallel=1 -count=1 -json
# test_go_project_path: integration-tests
# sui_cli_version: mainnet-1.60.1
# install_plugins_public: true
# free_disk_space: true
Copy link

Copilot AI Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment explaining why these tests are disabled and reference a tracking issue (e.g., 'Temporarily disabled due to flakiness - see LINK-777'). This helps maintainers understand when and why these tests should be re-enabled.

Copilot uses AI. Check for mistakes.
anirudhwarrier
anirudhwarrier previously approved these changes Dec 5, 2025
anirudhwarrier
anirudhwarrier previously approved these changes Dec 5, 2025
ro-tex
ro-tex previously approved these changes Dec 5, 2025
DylanTinianov
DylanTinianov previously approved these changes Dec 5, 2025
@FelixFan1992
Copy link
Contributor Author

added a ticket to track fixing these: https://smartcontract-it.atlassian.net/browse/NONEVM-2558

@FelixFan1992 FelixFan1992 dismissed stale reviews from ro-tex and anirudhwarrier via 6eeed22 December 5, 2025 16:21
@FelixFan1992 FelixFan1992 marked this pull request as draft December 5, 2025 17:22
@FelixFan1992 FelixFan1992 changed the title disable flaky tests temporarily disable flaky tests temporarily & update version Dec 5, 2025
@trunk-io
Copy link

trunk-io bot commented Dec 5, 2025

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@FelixFan1992 FelixFan1992 marked this pull request as ready for review December 5, 2025 19:26
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants