Skip to content

fix(actions): prevent unhandledRejection crash on WorkOS refresh failure #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
acmeguy merged 1 commit into from
Apr 23, 2026
Merged

fix(actions): prevent unhandledRejection crash on WorkOS refresh failure #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion services/actions/src/auth/token.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,12 @@ export default async function tokenHandler(req, res) {
return { accessToken: freshJwt, workosAccessToken: refreshResult.accessToken };
})();
inflightRefreshes.set(sessionId, refreshPromise);
refreshPromise.finally(() => inflightRefreshes.delete(sessionId));
// Swallow the rejection on this branch — `await refreshPromise` below owns the error.
// Without the catch, `.finally()` returns an unhandled rejected promise when refresh fails,
// which crashes the process via unhandledRejection.
refreshPromise
.finally(() => inflightRefreshes.delete(sessionId))
.catch(() => {});
}

try {
Expand Down
Loading