Release 5.4.0 #1795
Merged
Release 5.4.0 #1795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # base/src/main/java/com/smartdevicelink/managers/screen/menu/MenuReplaceUtilities.java
… on RPC connections v5.0 - v7.0
Feature/android 12 fixes
Codecov Report
@@ Coverage Diff @@
## master #1795 +/- ##
============================================
- Coverage 54.38% 54.02% -0.36%
- Complexity 5501 5520 +19
============================================
Files 562 562
Lines 25467 25757 +290
Branches 3317 3382 +65
============================================
+ Hits 13849 13915 +66
- Misses 10358 10579 +221
- Partials 1260 1263 +3
|
* Add UAI request to clean method in LCM This makes sure to send an UAI request when the LCM is shutting down to clear it from the head unit. Also removed redundent code to cose services and ignore the UAI response because there’s nothing the library can do at that point anyways. * Add missing initilize to JavaSE LCM * Fix incorrect start call when should stop in SdlManager * Add states to LCM * Prevent duplicate calls to SdlManager.dispose * Fix formatting issues for shutdown fix #1796 Co-authored-by: Julian Kast <[email protected]> Co-authored-by: Julian Kast <[email protected]>
…d strings (#1799) * Add error logging when removing empty commands * Switch from logging error to logging warnings * Update warning messages based on PR suggestions
* Fix RS exit foreground params * Refactor to call extiForeground for every close() In the RS * Fix altTransport timer issues preventing RS close * Fix incorrect spacing PR #1797 Co-authored-by: Julian Kast <[email protected]> Co-authored-by: Julian Kast <[email protected]>
This commit adds null checks and a List.size() check to PresentAlertOperation.supportsSoftButtonImages() These checks prevent crashes and returns true when soft button capabilities are unavailable This new behavior improves alignment with the other SDL libraries
* Improve handling of unsupported resolutions Adds a check in VirtualDisplayEncoder for unsupported resolutions that makes the virtual display encoder fail to start, prints a more helpful error message, and propagates an exception to the video stream manager Changes in VideoStreamManager now kill the video stream service when the encoder fails to start, allowing for subsequent streams to start after an encoder error * Add missing spaces to if statements
…icitly released -- state may be leaked", So I modified logic to release it if we have already created EglCore object and are creating a new one
…form an HMI state that was not streamable to one that is.
…t change in Texture2dProgram
…_error Fix auto restart video stream to ensure hmi level is streamable
noah-livio
approved these changes
Apr 13, 2022
noah-livio
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5.4.0 RC
This PR is [ready] for review.
Risk
This PR makes [minor] API changes.
Testing Plan
Summary
See the 5.4.0 Project
CLA