Skip to content

Andrew/ts config2 #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/node-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ jobs:
with:
node-version: ${{ matrix.node-version }}
- run: npm ci
- run: npm run build
- run: npm test
env:
CI: true
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,5 @@ __MACOSX
/.idea/
/node_modules/
/dist/
.env
.env
.rollup.cache/

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
export default class Sleeper {
constructor();
sleep(seconds: number): Promise<unknown>;
}

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2,575 changes: 1,494 additions & 1,081 deletions package-lock.json

Large diffs are not rendered by default.

21 changes: 13 additions & 8 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
],
"main": "dist/cjs/index.cjs",
"module": "dist/esm/index.mjs",
"types": "dist/types/index.d.ts",
"exports": {
".": {
"import": "./dist/esm/index.mjs",
Expand All @@ -45,18 +46,22 @@
"url": "github:smartystreets/smartystreets-javascript-sdk"
},
"devDependencies": {
"@babel/preset-env": "^7.25.8",
"@rollup/plugin-commonjs": "^28.0.1",
"@babel/preset-env": "^7.27.2",
"@rollup/plugin-commonjs": "^28.0.3",
"@rollup/plugin-json": "^6.1.0",
"@rollup/plugin-node-resolve": "^15.3.0",
"@rollup/plugin-node-resolve": "^16.0.1",
"@rollup/plugin-terser": "^0.4.4",
"@rollup/plugin-typescript": "^12.1.2",
"@types/node": "^22.15.17",
"chai": "^4.3.6",
"mocha": "^10.2.0",
"rollup": "^4.22.5",
"rollup-plugin-delete": "^2.1.0"
"mocha": "^11.2.2",
"rollup": "^4.40.2",
"rollup-plugin-delete": "^3.0.1",
"typescript": "^5.8.3"
},
"dependencies": {
"axios": "^1.7.7",
"axios-retry": "^4.5.0"
"axios": "^1.9.0",
"axios-retry": "^4.5.0",
"tslib": "^2.8.1"
}
}
22 changes: 15 additions & 7 deletions rollup.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -2,27 +2,29 @@ import del from "rollup-plugin-delete";
import commonjs from "@rollup/plugin-commonjs";
import json from "@rollup/plugin-json";
import terser from "@rollup/plugin-terser";
import { nodeResolve } from '@rollup/plugin-node-resolve';
import { nodeResolve } from "@rollup/plugin-node-resolve";
import typescript from "@rollup/plugin-typescript";

export default {
input: "index.mjs",
external: ["axios", "axios-retry"],
output: [
{
dir: "dist/cjs",
format: "cjs",
dir: "dist",
format: "esm",
preserveModules: true,
preserveModulesRoot: "src",
exports: "named",
entryFileNames: "[name].cjs",
entryFileNames: "esm/[name].mjs",
},
{
dir: "dist/esm",
format: "esm",
dir: "dist",
format: "cjs",
preserveModules: true,
preserveModulesRoot: "src",
exports: "named",
entryFileNames: "[name].mjs",
esModule: false,
entryFileNames: "cjs/[name].cjs",
},
],
plugins: [
Expand All @@ -33,5 +35,11 @@ export default {
}),
json(),
terser(),
typescript({
declaration: true,
emitDeclarationOnly: true,
outDir: "dist/types",
rootDir: "src"
}),
],
};
2 changes: 1 addition & 1 deletion src/ClientBuilder.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const StatusCodeSender = require("./StatusCodeSender");
const LicenseSender = require("./LicenseSender");
const BadCredentialsError = require("./Errors").BadCredentialsError;
const RetrySender = require("./RetrySender.js");
const Sleeper = require("./util/Sleeper.js");
const Sleeper = require("./util/Sleeper.ts");

//TODO: refactor this to work more cleanly with a bundler.
const UsStreetClient = require("./us_street/Client");
Expand Down
8 changes: 0 additions & 8 deletions src/util/Sleeper.js

This file was deleted.

6 changes: 6 additions & 0 deletions src/util/Sleeper.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
export default class Sleeper {
constructor () {}
sleep(seconds: number) {
return new Promise<void>((resolve: () => void) => setTimeout(resolve, seconds*1000));
}
}
2 changes: 1 addition & 1 deletion tests/test_ExtractExample.mjs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { expect } from "chai"; // Importing expect directly from chai
import SmartySDK from "../index.mjs"; // Importing SmartySDK
import SmartySDK from "../dist/esm/index.mjs"; // Importing SmartySDK

describe("Extract example test", () => {
const authId = "";
Expand Down
1 change: 0 additions & 1 deletion tests/us_street/test_Client.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
const chai = require("chai");
const expect = chai.expect;
const Client = require("../../src/us_street/Client");
const ClientBuilder = require("../../src/ClientBuilder");
const Lookup = require("../../src/us_street/Lookup");
const Candidate = require("../../src/us_street/Candidate");
const Batch = require("../../src/Batch");
Expand Down
39 changes: 39 additions & 0 deletions tsconfig.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
{
"compilerOptions": {
"emitDeclarationOnly": true,
"declaration": true,
"outDir": "dist/types",
"baseUrl": ".",
"paths": {
"@/*": ["./*"]
},
"allowJs": true,
"alwaysStrict": true,
"exactOptionalPropertyTypes": true,
"noPropertyAccessFromIndexSignature": true,
"noImplicitAny": true,
"noImplicitReturns": true,
"noImplicitOverride": true,
"noFallthroughCasesInSwitch": true,
"allowUnreachableCode": false,
"allowUnusedLabels": false,
"noImplicitThis": true,
"noUnusedLocals": true,
"noUnusedParameters": true,
"forceConsistentCasingInFileNames": true,
"skipLibCheck": true,
"strict": true,
"noEmit": true,
"incremental": true,
"module": "esnext",
"esModuleInterop": true,
"moduleResolution": "node",
"resolveJsonModule": true,
"isolatedModules": true,
"jsx": "preserve"
},
"include": ["src/**/*"],
"exclude": [
"node_modules"
]
}