Interface fix#24
Merged
Merged
Conversation
Summary of changes; - Fixed an issue related to the scaling of the constraint Jacobian when the `rhs` value for a Flume constraint was not equal to 1.0 or 0.0. pyOptSparse automatically applies the value for `scale` to the constraint value and the Jacobian entries, so manually scaling the Jacobian was incorrect - Removed the `it_counter` parameter from the System class within the `reset_analysis_flags` method. Now, the analysis flags are reset every time this method is called, regardless of the iteration number. This would have skipped the reset previously if `it_counter = 0`, which caused numerical issues for SNOPT's derivative check - Modified the tests for the ParOpt and pyOptSparse interfaces to reflect these changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed constraint Jacobian scaling for pyOptSparse interface. Also, removed the
it_counterparameter for thereset_analysis_flagsmethod within theSystemclass.