Silence git stderr noise from version stamping on non-git installs#2
Open
timryanb wants to merge 1 commit into
Open
Silence git stderr noise from version stamping on non-git installs#2timryanb wants to merge 1 commit into
timryanb wants to merge 1 commit into
Conversation
…t a git checkout Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pyNastran/init.py shells out to git describe and git show at import time to stamp a dev version. When pyNastran is pip-installed (no .git directory in site-packages), git prints fatal: not a git repository ... and Stopping at filesystem boundary ... directly to stderr. The Python exception is already caught and the version falls back cleanly, but the git CLI's own stderr leaks through since check_output only captures stdout. Any package importing pyNastran transitively (e.g. TACS) emits this noise once per process — 60 lines of each on a 60-rank MPI run.
This passes stderr=subprocess.DEVNULL to both calls so the failure stays silent. Version stamping behavior is unchanged: git checkouts still get 1.5.0+dev., non-checkouts still fall back to 1.5.0+dev.no.git.checksum.