fix: parameterize SQL queries in the db layer - #2028
Open
TrueFurina wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SpiderFootDb.scanElementParents()andscanElementChildrenDirect()buildtheir
IN (...)clause by string interpolation:The values are already whitelisted with
hashId.isalnum(), so there is nopractical injection vector (bandit B608 here is a static false positive), but
parameterized queries are the safer, idiomatic pattern — and they silence the
linter warning.
Change both queries to bind each hash as a
?parameter:Behavior is identical: one placeholder per hash, parameters passed through
the existing
execute(qry, qvars)path.Verification
python -m py_compile spiderfoot/db.py→ OKpytest test/unit/spiderfoot/ -k db→ 85 passed, 4 skipped(covers
test_spiderfootdb.py, incl. scan element parent/child lookups)Files changed
spiderfoot/db.py(2 query builders)