enable hyper1 behind BMV #3973
Merged
enable hyper1 behind BMV #3973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
landonxjames
approved these changes
Jan 21, 2025
Agreed. I'm working on customer messaging as next step and will seek feedback from team of course. |
ysaito1001
approved these changes
Jan 22, 2025
Comment on lines
+71
to
+74
| // TODO(hyper1): disable rustls as a default feature in future release | ||
| // NOTE: We enable both rustls and default-https-client as default features. This keeps the legacy hyper+rustls | ||
| // stack working as is and lets BehaviorVersion control which client you get. In a future release we will | ||
| // break this and disable the rustls feature by default (and break old BMV versions w.r.t http client default). |
2 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 10, 2025
## Motivation and Context <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here --> * #3710 * #1925 * awslabs/aws-sdk-rust#977 ## Description Updates the default HTTPS client to be based off hyper 1.x, rustls, and aws-lc. See the GitHub discussion: awslabs/aws-sdk-rust#1257 This PR is a rollup of previously reviewed PRs: * Refactor the runtime structure and consolidate HTTP client implementation(s): [smithy-rs#3866](#3866) * Migrate HTTP test utils: [smithy-rs#3888](#3888) * Update runtime to use new test utils: [smithy-rs#3898](#3898) * Backport connection poisoning: [smithy-rs#3795](#3795) * Deprecate HTTP 02x presign APIs: [smithy-rs#3823](#3823) * Enable hyper1 as default client: [smithy-rs#]() * Enable hyper1 behind BMV:[smithy-rs#3973](#3973) * s2n-tls provider (by Sam): [smithy-rs#3965](#3965) * custom TLS config: [smithy-rs#4032](#4032) ## Testing <!--- Please describe in detail how you tested your changes --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> ## Checklist <!--- If a checkbox below is not applicable, then please DELETE it rather than leaving it unchecked --> - [x] For changes to the smithy-rs codegen or runtime crates, I have created a changelog entry Markdown file in the `.changelog` directory, specifying "client," "server," or both in the `applies_to` key. - [x] For changes to the AWS SDK, generated SDK code, or SDK runtime crates, I have created a changelog entry Markdown file in the `.changelog` directory, specifying "aws-sdk-rust" in the `applies_to` key. ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._ --------- Co-authored-by: Sam Clark <[email protected]> Co-authored-by: Landon James <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Description
Follow up to #3939 to change how we enable hyper1 as the default.
default-https-client) and restores therustlsfeature to mean what it did before. Both will remain enabled asdefaultfeatures for some undetermined amount of time with the intent to removerustlsas a default feature as a breaking change in the future.default-https-client. This new flag when enabled and the appropriate min BMV is set will result in the new HTTPS stack being the default for clients. Otherwise we fallback to the old behavior (still requiresrustlsandconnector-hyper-0-14features enabled)By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.