Skip to content

fix(core): set sideEffects metadata #1648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 15, 2025
Merged

fix(core): set sideEffects metadata #1648

merged 1 commit into from
Jul 15, 2025

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Jul 14, 2025 •
edited
Loading

set the bundler metadata flag sideEffects to false in core and true in signature-v4a.

  • core is set to false to be explicit, since it has many submodules that should be tree-shaken as much as possible
  • sigv4a is set to true because it has module level code that injects an implementation into a container checked by signature-v4-multi-region

@kuhe kuhe requested a review from a team as a code owner July 14, 2025 19:50
@kuhe kuhe merged commit bb7975e into smithy-lang:main Jul 15, 2025
11 checks passed
@kuhe kuhe deleted the sideEffects branch July 15, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kuhe @trivikr