close #542 nancy rewritten to work with the new sdk #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please split the vendors in another commit? |
northdpole
force-pushed
the
nancy-to-new-sdk
branch
3 times, most recently
from
fea8ed9 to
4380198
Compare
northdpole
force-pushed
the
nancy-to-new-sdk
branch
from
4380198 to
71e412a
Compare
andream16
reviewed
Jan 28, 2025
| // NancyOut represents the output of a nancy run that we care about. | ||
| NancyOut struct { | ||
| Vulnerable []NancyAdvisory `json:"vulnerable"` | ||
| Audited []interface{} |
There was a problem hiding this comment.
Why are these so weakly typed?
There was a problem hiding this comment.
they are unused at the moment, changed to any and added a comment
ptzianos
reviewed
Jan 29, 2025
|
just a tiny nit and a rebase and it's good to 🚢 |
ptzianos
force-pushed
the
nancy-to-new-sdk
branch
from
71e412a to
b4b5637
Compare
northdpole
force-pushed
the
nancy-to-new-sdk
branch
from
b4b5637 to
2741bc3
Compare
andream16
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.