added keywords arguments for self.templates.TemplateResponse#1091
Closed
haykeminyan wants to merge 2 commits into
Closed
added keywords arguments for self.templates.TemplateResponse#1091haykeminyan wants to merge 2 commits into
haykeminyan wants to merge 2 commits into
Conversation
Member
|
Nice detail! If possible, do fix lint errors as well |
Author
Thanks! added linter fixes with .pre-commit-config.yaml |
mmzeynalli
requested changes
Jul 16, 2026
mmzeynalli
left a comment
Member
There was a problem hiding this comment.
I think there is minor issue. TemplateResponse we have in the code is not Starlette/FastAPI’s, but our own, in templating.py file. So, I believe, you only need update it there, and no need to touch anywhere else.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update here https://fastapi.tiangolo.com/advanced/templates/ now templateResponse demands use
this structure
previously was