Skip to content

customizable identity attribute for ModelView URL generation #922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
x23n5902y wants to merge 5 commits into
base: main
Choose a base branch
from
+3 −5
Draft

customizable identity attribute for ModelView URL generation #922

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7bc7de7
customizable identity attribute for ModelView URL generation
QsdRty May 27, 2025
7da7b90
format
QsdRty May 27, 2025
0a0774c
Merge branch 'main' into modelview-identity
aminalaee Jul 2, 2025
cadfc8c
Merge branch 'main' into modelview-identity
aminalaee Nov 26, 2025
e52c37a
Merge branch 'main' into modelview-identity
mmzeynalli Apr 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions sqladmin/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ def __new__(mcs, name, bases, attrs: dict, **kwargs: Any):
) from exc

cls.pk_columns = get_primary_keys(model)
cls.identity = slugify_class_name(model.__name__)
cls.identity = slugify_class_name(attrs.get("identity", model.__name__))

@mmzeynalli mmzeynalli Apr 6, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to do:

attrs.get("identity", slugify_class_name(model.__name__))

cls.model = model

cls.name = attrs.get("name", prettify_class_name(cls.model.__name__))
Expand Down Expand Up @@ -795,9 +795,7 @@ async def _run_query(self, stmt: ClauseElement) -> Any:
def _url_for_delete(self, request: Request, obj: Any) -> str:
pk = get_object_identifier(obj)
query_params = urlencode({"pks": pk})
url = request.url_for(
"admin:delete", identity=slugify_class_name(obj.__class__.__name__)
)
url = request.url_for("admin:delete", identity=self.identity)
return str(url) + "?" + query_params

def _url_for_details_with_prop(self, request: Request, obj: Any, prop: str) -> URL:
Expand All @@ -812,7 +810,7 @@ def _url_for_action(self, request: Request, action_name: str) -> str:
def _build_url_for(self, name: str, request: Request, obj: Any) -> URL:
return request.url_for(
name,
identity=slugify_class_name(obj.__class__.__name__),
identity=self.identity,
pk=get_object_identifier(obj),
)

Expand Down
Loading