Preact: Fix idle indicator persisting in userlist after users become active #2556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ISenseAura
reviewed
Nov 22, 2025
| } | ||
|
|
||
| handleJoinLeave(action: 'join' | 'leave', name: string, silent: boolean) { | ||
| if (action === 'join') { |
TurboRx
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
users' idle indicators (
@!) sometimes remained visible in the userlist even after they became active, particularly in rooms with custom rules or tournaments. the namecolor would update correctly but the idle marker would not clear.Root Cause
when
addUser()updates an existing user's entry, it modifiesonlineUsers[index]but doesn't re-sort the list. Since the sort key includes idle state (!name.endsWith('@!')), stale entries remain in the wrong position with incorrect idle indicators.