Skip to content

Preact: Fix highlight notifications during backlog and for self-authored messages #2578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
TurboRx wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Preact: Fix highlight notifications during backlog and for self-authored messages #2578

TurboRx wants to merge 2 commits into from

Conversation

@TurboRx
Copy link

@TurboRx TurboRx commented Dec 20, 2025 •
edited
Loading

  • Added an isHistory parameter to BattleLog.add() and the getHighlight callback
  • Modified handleHighlight in ChatRoom to suppress notifications when isHistory=true
  • Updated ChatLog.componentDidMount() to pass isHistory=true when processing backlog
  • Added a pure shouldNotifyHighlight helper function for testability
  • Added comprehensive unit tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@TurboRx