Skip to content

Conversation

@surfnWOB
Copy link

@surfnWOB surfnWOB commented Jan 3, 2026

In the Preact client, spectators and players joining a battle would appear grouped together at the current turn instead of at their correct historical positions in the battle log.

Changes:

  1. BattleRoom.receiveLine (new override in panel-battle.tsx):
  • Handles user list updates for join/leave/name
  • Routes messages to battle (if exists) or backlog (for later processing by BattlePanel)
  • Keeps ChatRoom clean with no battle-specific conditionals
  1. Battle.runMajor (simplified in battle.ts):
  • Join/leave/name handlers now just log the message
  • User list management delegated to BattleRoom

Testing:

  • Spectate a live battle or watch a replay
  • Join messages should appear at their correct historical positions

@surfnWOB surfnWOB force-pushed the fix-battle-roomjoins branch from 2e8d401 to b7ce7f8 Compare January 3, 2026 20:57
@surfnWOB surfnWOB marked this pull request as ready for review January 3, 2026 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant