Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

launchpad: add a script to fetch the creds #20

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

soumyaDghosh
Copy link
Member

This script can be used by anyone who'll be at the summit for the workshop. Taken from #18 by @lengau

Copy link
Contributor

@brlin-tw brlin-tw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the seemed-to-be-unnecessary blank line of line 8, LGTM.

That being said I don't really read Python so cannot verify the logic part of the patch.

@soumyaDghosh
Copy link
Member Author

Aside from the seemed-to-be-unnecessary blank line of line 8, LGTM.

That being said I don't really read Python so cannot verify the logic part of the patch.

May be, test it locally? I tested it and it's working. Also, will remove the last empty line.

@soumyaDghosh soumyaDghosh merged commit 73fb24c into snapcrafters:main Oct 16, 2024
@brlin-tw
Copy link
Contributor

@soumyaDghosh

May be, test it locally?

Thanks for the hint, for the record the patch works at my end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants