Fix mouse cursor theme issue #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This line leads to Alacritty using a white mouse cursor instead of the default cursor that would be expected (Yaru in most cases). I think that if someone wanted to modify this, they should address it upstream in [snapcraft-desktop-helpers](https://github.com/ubuntu/snapcraft-desktop-helpers), where XCURSOR_PATH is being modified without appending/preppending.
|
This change breaks the cursor on my system (Kubuntu), because the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address #21.
Unless I'm missing something, this environment variable (
XCURSOR_PATH) is set by thedesktop-launchwrapper that comes from thesnapcraft-desktop-helpersset of utilities in order to match the base theme on the workstation; unsetting this variable here undoes that work, and it leads to Alacritty using a white mouse cursor instead of falling back to the default cursor that would be expected (Yaru in most cases).I think that if someone wanted to modify this behavior (I noticed that this line was originally added to "respect user customization"), they should address it upstream in
snapcraft-desktop-helpers, where
XCURSOR_PATHis being modified without appending/preppending, but not in Alacritty.I've tested these changes locally and they seems to fix the cursor issue. Let me know what you think, or if I missed something in this!