feat: current gas proposal validation strategy #267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Implements a new proposal validation strategy that enforces a minimum ETH balance, adds corresponding tests, and cleans up related documentation.
- Introduce
CurrentGasProposalValidationStrategyto require proposers hold a configurable ETH threshold - Add unit tests (
CurrentGasProposalValidationStrategy.t.sol) to cover exactly-equal, above-threshold, and below-threshold cases - Remove a misplaced
@titlecomment inApeGasVotingStrategy.sol
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| test/CurrentGasProposalValidationStrategy.t.sol | Add tests for the new balance-threshold validation |
| src/voting-strategies/ApeGasVotingStrategy.sol | Remove redundant @title NatSpec comment |
| src/proposal-validation-strategies/CurrentGasProposalValidationStrategy.sol | Implement new validation strategy contract |
Comments suppressed due to low confidence (1)
src/voting-strategies/ApeGasVotingStrategy.sol:71
- [nitpick] There are two
@noticelines for this mapping; you might merge them into one@noticeand use@devfor detailed behavior to keep NatSpec concise.
/// @notice Maps an L1 block number to an L3 block number
src/proposal-validation-strategies/CurrentGasProposalValidationStrategy.sol
Show resolved
Hide resolved
src/proposal-validation-strategies/CurrentGasProposalValidationStrategy.sol
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/snapshot-labs/workflow/issues/566#issue-3097807282