-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add image aspect ratio for Bluesky #844
Conversation
Oh this is going to annoy the tests isn't it. Can we use a real image URL for the test data? |
Hah, yes. I think what you'd do is add a small image file to the granary/granary/tests/test_bluesky.py Lines 3481 to 3485 in c29dd72
|
That works, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test looks great! Thank you!
Looking good. One last minor nit, and then add this to the changelog in the readme, and I think we're set! |
Co-authored-by: Ryan Barrett <[email protected]>
Have added to README but please reword or move if it's wrong or in the wrong place :) |
Looks great! Thank you! Are you stlil set up to run this locally? It'd be nice to try interactively and see if it actually works. |
Awesome! Thank you for testing! OK, merging now, really psyched for this, thanks again for the contribution. |
Hey @snarfed, here's my attempt at adding the image aspect ratio. Please tear it apart with extreme prejudice, I haven't written Python for many months now.
I added Pillow as a dependency to Granary - do we need to add it to Bridgy too? It wouldn't work locally unless I installed it there but I probably am misunderstanding how the local installation stuff in Pip works.
Fixes #843