Add install/uninstall functions to Makefile#43
Open
TokinRing wants to merge 1 commit intosnavely:masterfrom
Open
Add install/uninstall functions to Makefile#43TokinRing wants to merge 1 commit intosnavely:masterfrom
TokinRing wants to merge 1 commit intosnavely:masterfrom
Conversation
Owner
|
Thank you for the pull request, TokinRing! One comment -- the two scripts for running the pipeline, RunBundler.sh utils/bundler.py both use the path of the scripts themselves to find the paths of the binaries. Can you think of an easy way to modify those scripts so that they look in the install locations if the binaries are there? I suppose one simple way would be to locally append the script directory to the PATH environment variable from within the script. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While trying to setup a package for Arch Linux, I found that the Makefile for this project does not have the ability to install and/or uninstall compiled executables and shared library.
I've added the install and uninstall functions to the Makefile. However, since there is already a preexisting bundler program (a Ruby gem), I've installed the compiled bundler executable as bundler_sfm instead.