Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1524259: Add option to build libsnowflakeclient as dynamic library #782

Open
wants to merge 63 commits into
base: master
Choose a base branch
from

Conversation

sfc-gh-ext-simba-jl
Copy link
Collaborator

@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl commented Nov 26, 2024

teamwork issue 1033
Add support for building libsnowflakeclient as a dynamic linking library.

@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl force-pushed the SNOW-1524259-dynamic-library branch from f7fcd62 to e95c698 Compare December 2, 2024 22:58
@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl force-pushed the SNOW-1524259-dynamic-library branch from 0f57b57 to e95c698 Compare December 11, 2024 01:02
@sfc-gh-dstempniak
Copy link
Collaborator

There are some problems on Windows:

2025-03-11T21:36:24.2952939Z test_async.obj : error LNK2019: unresolved external symbol _snowflake_init_async_query_result@8 referenced in function _test_new_connection [D:\a\libsnowflakeclient\libsnowflakeclient\cmake-build-win32-VS16-Debug\tests\test_async_dynamic.vcxproj]
2025-03-11T21:36:24.2956103Z test_async.obj : error LNK2019: unresolved external symbol _snowflake_get_query_status@4 referenced in function _test_long_query_get_query_status [D:\a\libsnowflakeclient\libsnowflakeclient\cmake-build-win32-VS16-Debug\tests\test_async_dynamic.vcxproj]
2025-03-11T21:36:24.2958777Z test_async.obj : error LNK2019: unresolved external symbol _snowflake_async_execute@4 referenced in function _test_normal_async_select_query [D:\a\libsnowflakeclient\libsnowflakeclient\cmake-build-win32-VS16-Debug\tests\test_async_dynamic.vcxproj]
2025-03-11T21:36:24.2961570Z test_async.obj : error LNK2019: unresolved external symbol _sf_sleep_ms referenced in function _test_long_query_get_query_status [D:\a\libsnowflakeclient\libsnowflakeclient\cmake-build-win32-VS16-Debug\tests\test_async_dynamic.vcxproj]
2025-03-11T21:36:24.4679560Z D:\a\libsnowflakeclient\libsnowflakeclient\cmake-build-win32-VS16-Debug\tests\Debug\test_async_dynamic.exe : fatal error LNK1120: 4 unresolved externals [D:\a\libsnowflakeclient\libsnowflakeclient\cmake-build-win32-VS16-Debug\tests\test_async_dynamic.vcxproj]

@sfc-gh-ext-simba-jl
Copy link
Collaborator Author

Hi @sfc-gh-dstempniak I've fixed the build error.

Copy link

codecov bot commented Mar 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.67%. Comparing base (39cc5d3) to head (214b7f3).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #782      +/-   ##
==========================================
+ Coverage   79.04%   80.67%   +1.63%     
==========================================
  Files         117      117              
  Lines       10369    10371       +2     
==========================================
+ Hits         8196     8367     +171     
+ Misses       2173     2004     -169     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants