SNOW-1865263 Remove VS14 support in libsnowflakeclient #824
+193
−323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sfc-gh-mmishchenko
commented
Feb 3, 2025
•
sfc-gh-mmishchenko
commented
- Drop VS14 build support
- Build Apache Arrow library from source by default
- Get rid of the environment variable which sets how the dependency on Apache Arrow is resolved (it's a cmake parameter now)
- Boost is explicitly built as a separate dependency but not as a part of Arrow
- Fix scripts/build_dependencies -t Debug
…pache Arrow from source by default
sfc-gh-dprzybysz
approved these changes
Feb 4, 2025
sfc-gh-mmishchenko
requested review from
sfc-gh-jszczerbinski and
sfc-gh-mkubik
sfc-gh-jszczerbinski
approved these changes
Feb 4, 2025
sfc-gh-mkubik
approved these changes
Feb 4, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #824 +/- ##
==========================================
- Coverage 80.53% 80.43% -0.10%
==========================================
Files 104 104
Lines 9223 9222 -1
==========================================
- Hits 7428 7418 -10
- Misses 1795 1804 +9 ☔ View full report in Codecov by Sentry. |
sfc-gh-jszczerbinski
requested changes
Feb 5, 2025
sfc-gh-jszczerbinski
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.