feat: [SNOW-2457402] Unify encoding support in SnowCLI#2792
Open
sfc-gh-kolszewski wants to merge 20 commits intomainfrom
Open
feat: [SNOW-2457402] Unify encoding support in SnowCLI#2792sfc-gh-kolszewski wants to merge 20 commits intomainfrom
sfc-gh-kolszewski wants to merge 20 commits intomainfrom
Conversation
…-encoding-support
This reverts commit 95257e2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Changes description
See https://snowflakecomputing.atlassian.net/browse/SNOW-2683933
This change adds new encoding configuration section with following keys:
Encoding settings are read from the configuration by SecurePath's read_text, write_text and open methods. As such, most places in the code where SecurePath was not used for these purposes were refactored to use SecurePath. I did not apply this change where encoding was already explicitly set as 'utf-8'
The change should be transparent to Unix users. Windows users can expect the warning to be displayed.