Skip to content

Commit

Permalink
SNOW-1660409: Fix directory permission for GET (#2080)
Browse files Browse the repository at this point in the history
  • Loading branch information
sfc-gh-dprzybysz authored Feb 18, 2025
1 parent 31d6a9c commit 808407a
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
7 changes: 4 additions & 3 deletions src/main/java/net/snowflake/client/jdbc/SnowflakeUtil.java
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,8 @@ public class SnowflakeUtil {
private static final SFLogger logger = SFLoggerFactory.getLogger(SnowflakeUtil.class);
private static final ObjectMapper OBJECT_MAPPER = ObjectMapperFactory.getObjectMapper();

private static final Set<PosixFilePermission> ownerOnlyPermission =
PosixFilePermissions.fromString("rw-------");
private static final Set<PosixFilePermission> directoryOwnerOnlyPermission =
PosixFilePermissions.fromString("rwx------");

/** Additional data types not covered by standard JDBC */
public static final int EXTRA_TYPES_TIMESTAMP_LTZ = 50000;
Expand Down Expand Up @@ -922,7 +922,8 @@ public static boolean createOwnerOnlyPermissionDir(String location) {
boolean isDirCreated = true;
Path dir = Paths.get(location);
try {
Files.createDirectory(dir, PosixFilePermissions.asFileAttribute(ownerOnlyPermission));
Files.createDirectory(
dir, PosixFilePermissions.asFileAttribute(directoryOwnerOnlyPermission));
} catch (IOException e) {
logger.error(
"Failed to set OwnerOnly permission for {}. This may cause the file download to fail ",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ public void testCreateOwnerOnlyPermissionDir(@TempDir Path tempDir)
assertTrue(tmp.toFile().isDirectory());
PosixFileAttributes attributes = Files.readAttributes(tmp, PosixFileAttributes.class);
Set<PosixFilePermission> permissions = attributes.permissions();
assertEquals(PosixFilePermissions.toString(permissions), "rw-------");
assertEquals(PosixFilePermissions.toString(permissions), "rwx------");
}

@Test
Expand Down

0 comments on commit 808407a

Please sign in to comment.