Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1890076: Ensure correct file is downloaded as stream #2043

Merged
merged 1 commit into from
Jan 27, 2025
Merged

SNOW-1890076: Ensure correct file is downloaded as stream #2043

merged 1 commit into from
Jan 27, 2025

Conversation

sfc-gh-dprzybysz
Copy link
Collaborator

Overview

SNOW-1890076

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:
  • Code is in compliance with internal logging requirements

@sfc-gh-dprzybysz sfc-gh-dprzybysz requested a review from a team as a code owner January 22, 2025 13:57
@sfc-gh-dszmolka sfc-gh-dszmolka mentioned this pull request Jan 22, 2025
Closed
@sfc-gh-dprzybysz sfc-gh-dprzybysz marked this pull request as draft January 23, 2025 06:36
@sfc-gh-dprzybysz sfc-gh-dprzybysz force-pushed the SNOW-1890076-ensure-correct-file-is-downloaded-as-stream branch from e911d0c to 7d0ce2e Compare January 23, 2025 13:57
@sfc-gh-dprzybysz sfc-gh-dprzybysz marked this pull request as ready for review January 23, 2025 13:57
@sfc-gh-dprzybysz sfc-gh-dprzybysz force-pushed the SNOW-1890076-ensure-correct-file-is-downloaded-as-stream branch from 7d0ce2e to 652021f Compare January 23, 2025 13:58
@sfc-gh-dprzybysz sfc-gh-dprzybysz force-pushed the SNOW-1890076-ensure-correct-file-is-downloaded-as-stream branch from 652021f to 6a73e1b Compare January 27, 2025 06:26
@sfc-gh-dprzybysz
Copy link
Collaborator Author

All the failing jobs has test errors that are going to be fixed in #2048

@sfc-gh-dprzybysz sfc-gh-dprzybysz merged commit 2355c5a into master Jan 27, 2025
122 of 142 checks passed
@sfc-gh-dprzybysz sfc-gh-dprzybysz deleted the SNOW-1890076-ensure-correct-file-is-downloaded-as-stream branch January 27, 2025 09:52
@github-actions github-actions bot locked and limited conversation to collaborators Jan 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-pmotacki sfc-gh-pmotacki sfc-gh-pmotacki approved these changes

@sfc-gh-pfus sfc-gh-pfus sfc-gh-pfus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-dprzybysz @sfc-gh-pmotacki @sfc-gh-pfus