Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snow 1925254 authentication logic refactor #2073

Merged
merged 11 commits into from
Feb 17, 2025

Conversation

sfc-gh-fpawlowski
Copy link
Contributor

@sfc-gh-fpawlowski sfc-gh-fpawlowski commented Feb 12, 2025

Overview

SNOW-1925254

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:
  • Code is in compliance with internal logging requirements

External contributors - please answer these questions before submitting a pull request. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Issue: #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency or upgrading an existing one
    • I am adding new public/protected component not marked with @SnowflakeJdbcInternalApi (note that public/protected methods/fields in classes marked with this annotation are already internal)
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-fpawlowski sfc-gh-fpawlowski self-assigned this Feb 12, 2025
@sfc-gh-fpawlowski sfc-gh-fpawlowski marked this pull request as ready for review February 12, 2025 13:14
@sfc-gh-fpawlowski sfc-gh-fpawlowski requested a review from a team as a code owner February 12, 2025 13:14
@sfc-gh-fpawlowski sfc-gh-fpawlowski merged commit 9005913 into master Feb 17, 2025
142 checks passed
@sfc-gh-fpawlowski sfc-gh-fpawlowski deleted the SNOW-1925254-Authentication-Logic-refactor branch February 17, 2025 12:42
@github-actions github-actions bot locked and limited conversation to collaborators Feb 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants