Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1660409: Fix directory permission for GET #2080

Merged
merged 1 commit into from
Feb 18, 2025
Merged

SNOW-1660409: Fix directory permission for GET #2080

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/main/java/net/snowflake/client/jdbc/SnowflakeUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,8 @@ public class SnowflakeUtil {
private static final SFLogger logger = SFLoggerFactory.getLogger(SnowflakeUtil.class);
private static final ObjectMapper OBJECT_MAPPER = ObjectMapperFactory.getObjectMapper();

private static final Set<PosixFilePermission> ownerOnlyPermission =
PosixFilePermissions.fromString("rw-------");
private static final Set<PosixFilePermission> directoryOwnerOnlyPermission =
PosixFilePermissions.fromString("rwx------");

/** Additional data types not covered by standard JDBC */
public static final int EXTRA_TYPES_TIMESTAMP_LTZ = 50000;
Expand Down Expand Up @@ -922,7 +922,8 @@ public static boolean createOwnerOnlyPermissionDir(String location) {
boolean isDirCreated = true;
Path dir = Paths.get(location);
try {
Files.createDirectory(dir, PosixFilePermissions.asFileAttribute(ownerOnlyPermission));
Files.createDirectory(
dir, PosixFilePermissions.asFileAttribute(directoryOwnerOnlyPermission));
} catch (IOException e) {
logger.error(
"Failed to set OwnerOnly permission for {}. This may cause the file download to fail ",
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/net/snowflake/client/jdbc/SnowflakeUtilTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ public void testCreateOwnerOnlyPermissionDir(@TempDir Path tempDir)
assertTrue(tmp.toFile().isDirectory());
PosixFileAttributes attributes = Files.readAttributes(tmp, PosixFileAttributes.class);
Set<PosixFilePermission> permissions = attributes.permissions();
assertEquals(PosixFilePermissions.toString(permissions), "rw-------");
assertEquals(PosixFilePermissions.toString(permissions), "rwx------");
}

@Test
Expand Down
Loading