SNOW-3121122: Bare bones support for SQLA2.1#654
Open
Dev-iL wants to merge 2 commits intosnowflakedb:mainfrom
Open
SNOW-3121122: Bare bones support for SQLA2.1#654Dev-iL wants to merge 2 commits intosnowflakedb:mainfrom
Dev-iL wants to merge 2 commits intosnowflakedb:mainfrom
Conversation
6f894ff to
11918b4
Compare
11918b4 to
05a55da
Compare
Member
|
Hey @Dev-iL 👋 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes (?) SNOW-3121122: Meta: Support for SQLAlchemy 2.1 #652
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
compat.pyIS_VERSION_21flag for preserving backward compatibility with SQLA 1.4 and 2.0._ORMSelectCompileState(private in 2.1) and re-exported asORMSelectCompileState.base.pySnowflakeORMSelectCompileStatenow inherits fromcompat.ORMSelectCompileState.SnowflakeSelectState._setup_joins: ported theexplicit_leftpattern from SQLA 2.1'sSelectState._setup_joins.SnowflakeORMSelectCompileState._join_left_to_right: ported theexplicit_leftpattern from SQLA 2.1's_ORMSelectCompileState._join_left_to_rightusing the appropriate snowflake classes.util.py_joined_from_info/ string onclause code behindnot IS_VERSION_21(since removed in SQLA 2.1)augment_onclauselogic with SQLA 2.1's upstream bug fix