Enhance documentation and tests for _CUSTOM_Time type to clarify time…#660
Merged
sfc-gh-jcieslak merged 1 commit intomainfrom Mar 3, 2026
Merged
Enhance documentation and tests for _CUSTOM_Time type to clarify time…#660sfc-gh-jcieslak merged 1 commit intomainfrom
sfc-gh-jcieslak merged 1 commit intomainfrom
Conversation
…zone handling. Added notes in README and unit tests to ensure correct compilation of time types in Snowflake dialect.
sfc-gh-mraba
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Follow-up for Add support for timestamps with timezone #649
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Adding documentation regarding the built-in TIME data type. Describes that Snowflake dialect doesn't support timezones for this type, and alternatives like timezone_tz should be used instead.