Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1888076: built-in function support wave1 #2928

Merged
merged 12 commits into from
Jan 28, 2025
Merged

SNOW-1888076: built-in function support wave1 #2928

merged 12 commits into from
Jan 28, 2025

Conversation

sfc-gh-aling
Copy link
Contributor

@sfc-gh-aling sfc-gh-aling commented Jan 24, 2025 •
edited
Loading

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1888076

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines

  3. Please describe how your code solves the related issue.

  • add new functions:
    • base64
    • base64_decode_string
    • base64_encode
    • editdistance
    • hex
    • hex_encode
    • instr
    • log1p
    • log2
    • log10
    • percentile_approx
    • unbase64
  • enhanced:
    • map_cat/map_concat now supports columns more than 2

@sfc-gh-aling sfc-gh-aling marked this pull request as ready for review January 24, 2025 19:28
@sfc-gh-aling sfc-gh-aling requested review from a team as code owners January 24, 2025 19:28
sfc-gh-aalam
sfc-gh-aalam reviewed Jan 24, 2025
View reviewed changes
@github-actions github-actions bot added the local testing Local Testing issues/PRs label Jan 28, 2025
sfc-gh-lspiegelberg
sfc-gh-lspiegelberg approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@sfc-gh-lspiegelberg sfc-gh-lspiegelberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@sfc-gh-aling sfc-gh-aling merged commit 7e510c9 into main Jan 28, 2025
37 checks passed
@sfc-gh-aling sfc-gh-aling deleted the SNOW-1888076-sma-pyspark-api-coverage branch January 28, 2025 02:21
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-lspiegelberg sfc-gh-lspiegelberg sfc-gh-lspiegelberg approved these changes

@sfc-gh-aalam sfc-gh-aalam sfc-gh-aalam approved these changes

@sfc-gh-yuwang sfc-gh-yuwang Awaiting requested review from sfc-gh-yuwang sfc-gh-yuwang is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-jrose sfc-gh-jrose Awaiting requested review from sfc-gh-jrose sfc-gh-jrose is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

Assignees
No one assigned
Labels
local testing Local Testing issues/PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-aling @sfc-gh-lspiegelberg @sfc-gh-aalam