Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1894152: Fix test_lineage_trace failure #2945

Merged
merged 5 commits into from
Jan 28, 2025
Merged

SNOW-1894152: Fix test_lineage_trace failure #2945

merged 5 commits into from
Jan 28, 2025

Conversation

sfc-gh-jrose
Copy link
Contributor

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1894152

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines

  3. Please describe how your code solves the related issue.

    The test example started failing due to a recent BCR that enabled secondary roles by default. The added statement should ensure that the test role is unable to see the data that is supposed to be masked in this test. For more information see here:
    https://community.snowflake.com/s/article/default-secondary-roles-all-overview-and-additional-explanations

@sfc-gh-jrose sfc-gh-jrose added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Jan 27, 2025
@sfc-gh-jrose sfc-gh-jrose marked this pull request as ready for review January 27, 2025 23:49
@sfc-gh-jrose sfc-gh-jrose requested a review from a team as a code owner January 27, 2025 23:49
sfc-gh-yli
sfc-gh-yli approved these changes Jan 28, 2025
View reviewed changes
Copy link

@sfc-gh-yli sfc-gh-yli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-jrose sfc-gh-jrose merged commit da41fac into main Jan 28, 2025
36 checks passed
@sfc-gh-jrose sfc-gh-jrose deleted the jrose_snow_1894152_fix_test_lineage_trace branch January 28, 2025 18:15
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-aling sfc-gh-aling sfc-gh-aling approved these changes

@sfc-gh-yli sfc-gh-yli sfc-gh-yli approved these changes

@sfc-gh-yixie sfc-gh-yixie Awaiting requested review from sfc-gh-yixie sfc-gh-yixie is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-yuwang sfc-gh-yuwang Awaiting requested review from sfc-gh-yuwang sfc-gh-yuwang is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-aalam sfc-gh-aalam Awaiting requested review from sfc-gh-aalam sfc-gh-aalam is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

Assignees
No one assigned
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-jrose @sfc-gh-yli @sfc-gh-aling