Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supporting stored procs in decoder #2947

Merged
merged 8 commits into from
Jan 29, 2025
Merged

Supporting stored procs in decoder #2947

merged 8 commits into from
Jan 29, 2025
+23 −6

Conversation

sfc-gh-batur
Copy link
Contributor

@sfc-gh-batur sfc-gh-batur commented Jan 28, 2025 •
edited by sfc-gh-vbudati
Loading

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1830568

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-batur sfc-gh-batur marked this pull request as ready for review January 28, 2025 19:21
@sfc-gh-batur sfc-gh-batur requested a review from a team as a code owner January 28, 2025 19:21
sfc-gh-vbudati
sfc-gh-vbudati reviewed Jan 28, 2025
View reviewed changes
tests/ast/test_ast_driver.py Outdated
@@ -195,6 +195,7 @@ def compare_base64_results(
actual_message: proto.Request,
expected_message: proto.Request,
exclude_symbols_udfs_and_src: bool = False,
test_case: TestCase = None,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not just take the test case name as the parameter instead of the whole test case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly in case we wanted more information from the test case, but, that's something we can do when there is a need for it..

@sfc-gh-batur sfc-gh-batur merged commit 8dc9224 into vbudati/SNOW-1794510-merge-decoder Jan 29, 2025
6 checks passed
@sfc-gh-batur sfc-gh-batur deleted the sproc_test branch January 29, 2025 23:23
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-vbudati sfc-gh-vbudati sfc-gh-vbudati approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-batur @sfc-gh-vbudati