Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1805854: Reformat interoperability docs page #2951

Merged
merged 8 commits into from
Jan 30, 2025
Merged

SNOW-1805854: Reformat interoperability docs page #2951

merged 8 commits into from
Jan 30, 2025

Conversation

sfc-gh-lmukhopadhyay
Copy link
Contributor

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1805854

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines

  3. Please describe how your code solves the related issue.

Reformats interoperability docs page.

@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Jan 28, 2025
@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay marked this pull request as ready for review January 29, 2025 00:24
@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay requested a review from a team as a code owner January 29, 2025 00:24
sfc-gh-mvashishtha
sfc-gh-mvashishtha approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@sfc-gh-mvashishtha sfc-gh-mvashishtha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from some nits. Thanks!

docs/source/modin/interoperability.rst Outdated Show resolved Hide resolved
docs/source/modin/interoperability.rst Outdated Show resolved Hide resolved
docs/source/modin/interoperability.rst Outdated Show resolved Hide resolved
docs/source/modin/interoperability.rst Outdated Show resolved Hide resolved
docs/source/modin/interoperability.rst Outdated Show resolved Hide resolved
@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay enabled auto-merge (squash) January 29, 2025 23:48
@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay merged commit 3e4da09 into main Jan 30, 2025
29 of 38 checks passed
@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay deleted the lmukhopadhyay-SNOW-1805854-update-3pl-docs branch January 30, 2025 06:30
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-dolee sfc-gh-dolee sfc-gh-dolee approved these changes

@sfc-gh-mvashishtha sfc-gh-mvashishtha sfc-gh-mvashishtha approved these changes

@sfc-gh-amaheshwary sfc-gh-amaheshwary Awaiting requested review from sfc-gh-amaheshwary sfc-gh-amaheshwary is a code owner automatically assigned from snowflakedb/snowpark-pandas-api

Assignees
No one assigned
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-lmukhopadhyay @sfc-gh-mvashishtha @sfc-gh-dolee