Skip to content

Conversation

@nezia1
Copy link
Collaborator

@nezia1 nezia1 commented Oct 15, 2025

Reverts #118, as in the path type expects an absolute path so the type will not work with our use-case and breaks Hjem for everyone. I apologize for merging this, I thought the path type would work here.

I believe we do have to run asserts to check if it's a path-like string, but we cannot use the path type

@alfarelcynthesis
Copy link

The default is notably also invalid, so the entire gtk module in main is currently broken and not easily fixable without modifying option declarations to change the type.

Copy link
Member

@GetPsyched GetPsyched left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this was broken, I'd assume there's no need for mkRemovedOptionModule.

I'd want a breaking change like this to roll-forward instead of rolling-back, but might be acceptable still given a part of the module was broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants